Getting a code review
Here's what to do when you want a code review.
Invite your code-reviewer(s) as project collaborator(s)
You will be told who your code-reviewer(s) will be.
Ask your assigned code-reviewer(s) for their github usernames.
Go to your
tv-show-dom-project
repoClick
Settings
Click
Manage access
For each reviewer you have been assigned:
- Click
Invite a collaborator
- Type the github username of the reviewer, and select them
- Click
Add <username> to tv-show-dom-project
- Click
Make a PR and request review
- Make a PR from
master
to yourfor-review
branch. - Click the settings cog-wheel next to Reviewers
- For each reviewer you have been assigned
- enter the reviewer's username and select them
- DM your reviewer on slack to say that your code is ready for review
❗
Note: you should NEVER merge this PR into the for-review
branch.
❗
Giving a code review
Read the Giving Feedback page for how to do this.